Skip to content

[Snyk] Fix for 4 vulnerabilities#11565

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-46596db97bec8656f04d9becfd07283a
Closed

[Snyk] Fix for 4 vulnerabilities#11565
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-46596db97bec8656f04d9becfd07283a

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Jan 31, 2026

snyk-top-banner

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/cloudbuild/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  61  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Directory Traversal


EntelligenceAI PR Summary

This PR pins Backstage dependency versions in the cloudbuild plugin package.json, replacing workspace protocol references with specific versions.

  • Changed @backstage/core-components from workspace:^ to 0.8.6
  • Changed @backstage/theme from workspace:^ to 0.1.1
  • Locks dependencies to specific versions instead of using monorepo workspace resolution
  • May indicate preparation for independent package publishing or specific version compatibility requirements

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jan 31, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading two @backstage dependencies within the plugins/cloudbuild package. The updates target specific versions to remediate four identified medium-severity vulnerabilities, including Directory Traversal, Regular Expression Denial of Service (ReDoS), and Uncontrolled Recursion.

Highlights

  • Dependency Updates: The pull request updates @backstage/core-components from workspace:^ to 0.8.6 and @backstage/theme from workspace:^ to 0.1.1 in the plugins/cloudbuild/package.json file.
  • Vulnerability Fixes: These dependency upgrades address four medium-severity vulnerabilities: two Directory Traversal issues (SNYK-JS-TAR), one Regular Expression Denial of Service (ReDoS) (SNYK-JS-DIFF), and one Uncontrolled Recursion (SNYK-JS-ESLINT).
  • Yarn Lock Warning: A warning is present indicating that the yarn.lock file was not updated by Snyk and requires manual intervention. This is particularly relevant for projects utilizing Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Jan 31, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix security vulnerabilities by pinning dependencies. However, the changes introduce a critical issue by replacing workspace:^ specifiers with fixed, outdated versions for @backstage/core-components and @backstage/theme. This breaks the monorepo's workspace linking and significantly downgrades these packages, which will likely lead to build failures or runtime errors. The fact that Snyk failed to update yarn.lock further indicates that these changes are incorrect for this project's structure. I've added a comment explaining the issue in detail and provided a code suggestion to revert the changes. The vulnerabilities should be addressed differently, for example by using resolutions in the root package.json.

Comment on lines +37 to +40
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces workspace:^ with pinned, older versions of @backstage/core-components and @backstage/theme. This breaks the monorepo's workspace linking, causing this package to use outdated versions from the public registry instead of the up-to-date versions from this repository.

  • @backstage/core-components is being downgraded from workspace version 0.13.4-next.0 to 0.8.6.
  • @backstage/theme is being downgraded from workspace version 0.4.1 to 0.1.1.

This significant downgrade is very likely to cause build failures or runtime errors. The automated Snyk fix does not seem to correctly handle yarn workspaces. The vulnerabilities should be addressed without breaking the workspace setup, for example by updating the root dependencies that bring in the vulnerable packages, or by using yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of the transitive dependencies.

Suggested change
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates dependency management for the cloudbuild plugin by replacing workspace protocol references with pinned versions for two Backstage packages. The @backstage/core-components dependency is locked to version 0.8.6 and @backstage/theme to version 0.1.1. This change moves away from monorepo workspace resolution to explicit version pinning, which typically indicates a requirement for specific version compatibility or preparation for publishing the plugin as an independent package outside the monorepo context.

Changes

File(s) Summary
plugins/cloudbuild/package.json Replaced workspace protocol (workspace:^) with pinned versions for @backstage/core-components (0.8.6) and @backstage/theme (0.1.1) dependencies.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PKG as cloudbuild/package.json
    participant WS as Workspace Dependencies
    participant NPM as NPM Registry

    Note over Dev,NPM: Dependency Resolution Change

    Dev->>PKG: Update dependency versions
    
    rect rgb(255, 240, 240)
        Note over PKG,WS: Before: Workspace References
        PKG->>WS: Resolve @backstage/core-components (workspace:^)
        PKG->>WS: Resolve @backstage/theme (workspace:^)
    end
    
    rect rgb(240, 255, 240)
        Note over PKG,NPM: After: Pinned Versions
        PKG->>NPM: Resolve @backstage/core-components (0.8.6)
        PKG->>NPM: Resolve @backstage/theme (0.1.1)
    end
    
    Note over Dev,NPM: Impact: Plugin now uses external<br/>versioned dependencies instead of<br/>local workspace packages
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 7, 2026

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 7, 2026
@github-actions github-actions Bot closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants